Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categorisation of notation rules #4766

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 12, 2020

Which issue, if any, is this issue related to?

Relates to #4760, #4721 and #4720.

Is there anything in the PR that needs further explanation?

These existing three rules belong in the limit language features category as none are just stylistic. For example, selector-pseudo-element-colon-notation, like the upcoming color-function-notation rule, is about compatibility.

The stylistic category becomes only concerned with whitespace, case, quotes and trailing/leading zeroes.

@jeddy3 jeddy3 mentioned this pull request May 14, 2020
6 tasks
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeddy3 jeddy3 merged commit b3c6eb2 into master May 16, 2020
@jeddy3 jeddy3 deleted the fix-categories-notation branch May 16, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants