Add ignoreFunctions: [] to value-keyword-case #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeddy3
approved these changes
May 6, 2020
There was a problem hiding this comment.
@malsf21 Looks good to me, thanks!
I was going to suggest using the optionsMatches util, but I see the rule doesn't use it yet for any of the ignore options. I'll create a follow-up refactor issue for that.
m-allanson
approved these changes
May 12, 2020
jeddy3
changed the title
|
Changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a PR that adds an
ignoreFunctions: []option to thevalue-keyword-caserule, as requested in #4648! I did this by adding the option to the valid option list, and then usingmatchesStringOrRegExpon the passed-in options. I also added tests based off of the discussion in the issue comments, and added documentation on the option to the rule's documentation page.On my end, I ran
npm run formatandnpm run test, and everything seems to work as intended. Let me know if there are any edge-cases/tests that I should add to the PR!Closes #4648.
Nope!