Reinstate and document workaround feature #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 11, 2020
Merged
Merged
Closed
jeddy3
changed the title
ntwb
reviewed
Feb 14, 2020
ybiquitous
reviewed
Feb 14, 2020
ybiquitous
reviewed
Feb 14, 2020
|
|
||
| interface Input { | ||
| css?: string; | ||
| } |
There was a problem hiding this comment.
[note] This css property is missing the official PostCSS type definitions:
| interface NodeSource { | ||
| lang?: string; | ||
|
|
||
| } |
There was a problem hiding this comment.
[note] This lang property seems an extension by postcss-syntax. I cannot find it in the PostCSS core repository.
There was a problem hiding this comment.
Do you know what the best way of handling this is?
There was a problem hiding this comment.
No, I'm not sure now. 😣
This solution seems best for us now.
ybiquitous
reviewed
Feb 14, 2020
Co-Authored-By: Stephen Edgar <stephen@netweb.com.au>
Co-Authored-By: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-Authored-By: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If time is short, please review this pull request over #4591 so that we can address #3514.)
Follow on from #4573
This pull request is also part of the stream of work to better surface syntaxes so that we can muster support for them. After we merge this pull request, I plan to post comments on the issues mentioned in #4574 pointing to this new feature.
--
I'm not sure how it happened, but buried at the bottom of #4588 were some changes that reverted the actual workaround feature added in #4573. I've recovered those changes in this pull request.