Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #4591

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Improve documentation #4591

merged 4 commits into from
Feb 14, 2020

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Feb 10, 2020

(If time is short, please review #4592 over over this pull request so that we can address #3514.)

Follow up from #4561

I went through the overhauled docs again now that they are live on the website.

I want to make sure the:

  • sidebars worked well
  • content was a clear as it could be when view on the website

In this pull request I:

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

(I left some nitpicks, but you don't always need to address them.)

docs/developer-guide/rules.md Outdated Show resolved Hide resolved
docs/user-guide/configure.md Outdated Show resolved Hide resolved
jeddy3 and others added 2 commits February 13, 2020 20:19
Co-Authored-By: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Co-Authored-By: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
@jeddy3
Copy link
Member Author

jeddy3 commented Feb 14, 2020

@ybiquitous Thanks for suggestions. I accepted them both.

@jeddy3 jeddy3 merged commit 20d1a96 into master Feb 14, 2020
@jeddy3 jeddy3 deleted the improve-docs-3 branch February 14, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants