Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Node.js 8 #4500

Merged
merged 3 commits into from Jan 9, 2020
Merged

Drop Node.js 8 #4500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
914cd5a
Drop Node.js 8
hudochenkov Dec 29, 2019
3cc141d
Remove engine field
hudochenkov Jan 2, 2020
dbda6ad
Fix ESLint configuration
hudochenkov Jan 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@ jobs:

strategy:
matrix:
node-version: [8, 10, 12]
node-version: [10, 12]
os: [ubuntu-latest, windows-latest, macos-latest]
exclude:
- os: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/prerequisites.md
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@

## Technical

- Minimum [Node.js](https://nodejs.org/en/) v8.7.0+, though we do recommend using the latest 8.x, 10.x, or 11.x Node.js releases.
- Minimum [Node.js](https://nodejs.org/en/) v10, though we do recommend using the latest LTS release.
- Latest [npm](https://www.npmjs.com/).

## Rules of thumb
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@
"!lib/testUtils"
],
"engines": {
"node": ">=8.7.0"
"node": ">=10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better start to support with LTS, i.e. 10.13.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some users had problem, when we set minor version too high: #4000. But it's not longer the case:

Starting with Node 10, AWS Lambda will also automatically update the language minor versions to latest minor version, as specified by https://github.com/nodejs/Release.

https://aws.amazon.com/about-aws/whats-new/2019/05/aws_lambda_adds_support_for_node_js_v10/

So I guess we can even put latest 10.18.0 as the minimum.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think allowing for edge cases like what happened in #4000 is fine, min v10.0.0 I think will be ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless a specific feature is required from a version newer than 10.0.0, we can just go with 10.0.0. Just note that CI tests the latest release line and this can be problematic in some cases. It might be wiser to test the minimum supported Node.js version at the time instead.

},
"dependencies": {
"autoprefixer": "^9.7.2",
Expand Down