New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node.js 8 #4500
Drop Node.js 8 #4500
Conversation
package.json
Outdated
@@ -40,7 +40,7 @@ | |||
"!lib/testUtils" | |||
], | |||
"engines": { | |||
"node": ">=8.7.0" | |||
"node": ">=10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better start to support with LTS, i.e. 10.13.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some users had problem, when we set minor version too high: #4000. But it's not longer the case:
Starting with Node 10, AWS Lambda will also automatically update the language minor versions to latest minor version, as specified by https://github.com/nodejs/Release.
https://aws.amazon.com/about-aws/whats-new/2019/05/aws_lambda_adds_support_for_node_js_v10/
So I guess we can even put latest 10.18.0 as the minimum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think allowing for edge cases like what happened in #4000 is fine, min v10.0.0 I think will be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless a specific feature is required from a version newer than 10.0.0, we can just go with 10.0.0. Just note that CI tests the latest release line and this can be problematic in some cases. It might be wiser to test the minimum supported Node.js version at the time instead.
package.json
Outdated
@@ -40,7 +40,7 @@ | |||
"!lib/testUtils" | |||
], | |||
"engines": { | |||
"node": ">=8.7.0" | |||
"node": ">=10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think allowing for edge cases like what happened in #4000 is fine, min v10.0.0 I think will be ok
I would declare minimum supported version as latest Node.js 10 LTS release, but remove We might not be using any Node.js latest features, but I don't want to be locked in old releases. I work on a free software and spent my life to work on it. Users can upgrade their Node.js version with no problem. If stylelint works on Node.js 10.0.0. It's great, but it won't be supported version. Removing Also consider our dependencies which specify they drop Node.js 8. We don't know on what exact version of Node.js 10 they will work (except the very latest release). If we specify supported version as 10.0.0, but our dependency needs 10.2.0, we kind of messing with our users. |
Looks like we'd have to update eslint-config-stylelint with this:
{
"node/no-unsupported-features/es-syntax": ["error", {
"version": ">=10.0.0",
"ignores": []
}]
} |
As per my comment (#4500 (comment)) I put latest v10 LTS into ESLint config. |
@stylelint/contributors does anyone have time to review this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree!
|
End of life on 31st December.