Fix empty lines rules #4260
Merged
Fix empty lines rules #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vankop
commented
Sep 7, 2019
| report({ | ||
| message: messages.expected(max), | ||
| node: decl, | ||
| index: placeIndexOnValueStart(decl) + node.sourceIndex, |
There was a problem hiding this comment.
so for function-max-empty-lines column will be set to start of the function
a { transform: translate() }
/* ↑ */
/* column will start here */
vankop
commented
Sep 7, 2019
| report({ | ||
| message: messages.expected(max), | ||
| node: rule, | ||
| index: 0, |
There was a problem hiding this comment.
for selector-max-empty-lines column set to start of selector
vankop
commented
Sep 7, 2019
| report({ | ||
| message: messages.expected(max), | ||
| node: decl, | ||
| index: 0, |
There was a problem hiding this comment.
for value-list-max-empty-lines column set to start of the property
jeddy3
approved these changes
Sep 10, 2019
alexander-akait
approved these changes
Sep 10, 2019
|
@vankop could you help summarize this PR in one sentence for commit message and changelog entry, please? :) |
|
Rework |
|
In Changelog parlance:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #4232 . Now there is no extra warnings.
fix:
function-max-empty-linesselector-max-empty-linesvalue-list-max-empty-linesOnly for
value-list-max-empty-lineswas test case with comments with exited max empty lines length, so only in the end of this work I realized that comments inside rule range are skipped =(Also there is no info in README about it
If this behavior must be restored I can rework