Skip to content

Commit

Permalink
Fix *-max-empty-lines to only report one violation per function, sele…
Browse files Browse the repository at this point in the history 
…ctor, value list (#4260)

* fix: selector-max-empty-lines

* fix: function-max-empty-lines

* fix: value-list-max-empty-lines

* fix tests
  • Loading branch information
@vankop @hudochenkov
vankop authored and hudochenkov committed Sep 13, 2019
1 parent 2c5bcb6 commit 0858782
Show file tree
Hide file tree
Showing 7 changed files with 492 additions and 618 deletions.
92 changes: 46 additions & 46 deletions lib/rules/function-max-empty-lines/__tests__/index.js
View file
Expand Up @@ -54,84 +54,84 @@ testRule(rule, {
fixed: "a { transform: translate(/*c*/\n1,1); }",
message: messages.expected(0),
line: 1,
column: 31
column: 15
},
{
code: "a { transform: /*c*/translate(\n\n\n1,1); }",
fixed: "a { transform: /*c*/translate(\n1,1); }",
message: messages.expected(0),
line: 1,
column: 31
column: 20
},
{
code: "a { transform: translate(\n\n1\n,\n1\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\n\n1\n,\n1\n\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\n\n1\n\n,\n1\n\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\r\n\r\n1\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(0),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\n1\n\n,\n1\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(0),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n\n1\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(0),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n1\n\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n); }",
message: messages.expected(0),
line: 4,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n1\r\n\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(0),
line: 4,
column: 2
line: 1,
column: 15
}
]
});
Expand Down Expand Up @@ -180,56 +180,56 @@ testRule(rule, {
fixed: "a { transform: translate(\n\n1\n,\n1\n); }",
message: messages.expected(1),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\r\n\r\n\r\n1\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(1),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\n1\n\n\n,\n1\n); }",
fixed: "a { transform: translate(\n1\n\n,\n1\n); }",
message: messages.expected(1),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n\r\n\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n\r\n,\r\n1\r\n); }",
message: messages.expected(1),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n\n\n1\n); }",
fixed: "a { transform: translate(\n1\n,\n\n1\n); }",
message: messages.expected(1),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n\r\n\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n\r\n1\r\n); }",
message: messages.expected(1),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n1\n\n\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n\n); }",
message: messages.expected(1),
line: 4,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n1\r\n\r\n\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n\r\n); }",
message: messages.expected(1),
line: 4,
column: 2
line: 1,
column: 15
}
]
});
Expand Down Expand Up @@ -302,56 +302,56 @@ testRule(rule, {
fixed: "a { transform: translate(\n\n\n1\n,\n1\n); }",
message: messages.expected(2),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\r\n\r\n\r\n\r\n1\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n\r\n\r\n1\r\n,\r\n1\r\n); }",
message: messages.expected(2),
line: 1,
column: 26
column: 15
},
{
code: "a { transform: translate(\n1\n\n\n\n,\n1\n); }",
fixed: "a { transform: translate(\n1\n\n\n,\n1\n); }",
message: messages.expected(2),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n\r\n\r\n\r\n,\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n\r\n\r\n,\r\n1\r\n); }",
message: messages.expected(2),
line: 2,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n\n\n\n1\n); }",
fixed: "a { transform: translate(\n1\n,\n\n\n1\n); }",
message: messages.expected(2),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n\r\n\r\n\r\n1\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n\r\n\r\n1\r\n); }",
message: messages.expected(2),
line: 3,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\n1\n,\n1\n\n\n\n); }",
fixed: "a { transform: translate(\n1\n,\n1\n\n\n); }",
message: messages.expected(2),
line: 4,
column: 2
line: 1,
column: 15
},
{
code: "a { transform: translate(\r\n1\r\n,\r\n1\r\n\r\n\r\n\r\n); }",
fixed: "a { transform: translate(\r\n1\r\n,\r\n1\r\n\r\n\r\n); }",
message: messages.expected(2),
line: 4,
column: 2
line: 1,
column: 15
}
]
});

0 comments on commit 0858782

Please sign in to comment.