Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore calc() in length-zero-no-unit #4175

Merged
merged 12 commits into from Aug 11, 2019
Merged

Ignore calc() in length-zero-no-unit #4175

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
297d8db
fixes #3037
vankop Jul 26, 2019
5dd12b0
fix discussions
vankop Jul 26, 2019
76501f2
isMathFunction util function
vankop Jul 26, 2019
8ed5186
add tests, remove isMathFunction, add getMathFunctionsRanges
vankop Jul 27, 2019
d37e933
improve getMathFunctionsRanges
vankop Jul 27, 2019
fedba5a
added isMathFunction, rework creation of ignorableIndexes
vankop Jul 27, 2019
f294149
add some tests
vankop Jul 27, 2019
dbcefbf
update README.md
vankop Jul 31, 2019
0e69ed6
update README.md one more
vankop Jul 31, 2019
37e4cab
update README.md
vankop Jul 31, 2019
338bb1f
move math functions definition to references
vankop Jul 31, 2019
eb32f00
fix README
vankop Aug 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/utils/getMathFunctionsRanges.js
View file
Open in desktop
@@ -1,12 +1,16 @@
"use strict";

const MATH_REGEXP = /calc\([^()]*(?:\(.*\))*[^()]*\)/gi;
const MATH_FUNCTIONS = ["calc"];
const MATH_FUNCTIONS_REGEXP = new RegExp(
`(?:${MATH_FUNCTIONS.join("|")})` + "\\([^()]*(?:\\(.*\\))*[^()]*\\)",
"gi"
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use regexp for this cases, we have postcss-value-parser, regexp is slow and unsafe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌


module.exports = function getMathFunctionsRanges(valueString) {
const result = [];
let current;

while ((current = MATH_REGEXP.exec(valueString)) !== null) {
while ((current = MATH_FUNCTIONS_REGEXP.exec(valueString)) !== null) {
result.push([current.index, current.index + current[0].length]);
}

Expand Down