Ignore calc() in length-zero-no-unit #4175
Conversation
| check(blurComments(decl.toString()), decl); | ||
| const stringValue = blurComments(decl.toString()); | ||
|
|
||
| if (!/calc\((.|\s)*\)/i.test(stringValue)) { |
There was a problem hiding this comment.
Let's move this to util and name file isMathFunction and put logic in utils (in next css spec we will have more math functions, not only calc)
| { | ||
| description: "ignore calc. empty calc", | ||
| code: "a { padding: calc(); }" | ||
| }, |
There was a problem hiding this comment.
Can we add test like padding: calc(1in + 0in * 2)) 0in, should have one error
There was a problem hiding this comment.
awesome suggestion. I have improve it to padding: calc(1in + 0in * 2)) 0in calc(0px) 0px since it was needed to rework regexp, too
|
|
||
| message: messages.rejected, | ||
| line: 1, | ||
| column: 36 |
There was a problem hiding this comment.
And other hardcore example: padding: calc(var(--foo, 0in) + 10px) 0in 😄
There was a problem hiding this comment.
ignore: ["custom-properties"] does not work with such example, is it a bug?
There was a problem hiding this comment.
i think yes, we catch a bug
lib/utils/getMathFunctionsRanges.js
Outdated
| const MATH_FUNCTIONS_REGEXP = new RegExp( | ||
| `(?:${MATH_FUNCTIONS.join("|")})` + "\\([^()]*(?:\\(.*\\))*[^()]*\\)", | ||
| "gi" | ||
| ); |
There was a problem hiding this comment.
Please don't use regexp for this cases, we have postcss-value-parser, regexp is slow and unsafe
| @@ -1,6 +1,6 @@ | |||
| # length-zero-no-unit | |||
|
|
|||
| Disallow units for zero lengths. | |||
| Disallow units for zero lengths. Ignores `calc` value in favor of `function-calc-no-invalid` rule. | |||
There was a problem hiding this comment.
Minor doc nitpick. Let's revert the change to this sentence and add the following below the example:
This rule ignores lengths within `calc` functions in favor of the [`function-calc-no-invalid`](../function-calc-no-invalid/README.md) rule.This is to be consistent with other rule READMEs e.g.
https://github.com/stylelint/stylelint/tree/master/lib/rules/font-family-name-quotes#font-family-name-quotes
Otherwise, this PR LGTM.
|
|
||
| Disallow units for zero lengths. | ||
| Disallow units for zero lengths. This rule ignores lengths within math functions (e.g. `calc`) in favor of the [`function-calc-no-invalid`](../function-calc-no-invalid/README.md) rule. |
There was a problem hiding this comment.
Can you please move the "This rule ignores" sentence to below the example code block as we use this documentation pattern in lots of other places (like so).
lib/utils/isMathFunction.js
Outdated
| module.exports = function isMathFunction(node /*: Object */) /*: boolean*/ { | ||
| return ( | ||
| node.type === "function" && | ||
| MATH_FUNCTIONS.indexOf(node.value.toLowerCase()) > -1 |
There was a problem hiding this comment.
We can use this MATH_FUNCTIONS.includes(node.value.toLowerCase()), indexOf is very old, we can use more readable code 😄
And move MATH_FUNCTIONS to https://github.com/stylelint/stylelint/tree/master/lib/reference for better maintenance
hudochenkov
changed the title
|
Closes #3037
nothing