Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value-keyword-case in scss list #4019

Merged
merged 2 commits into from Apr 13, 2019
Merged

Fix value-keyword-case in scss list #4019

merged 2 commits into from Apr 13, 2019

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Apr 11, 2019 •
edited

The problem is that parsed.toString() converts // with /* I avoid this converting not calling the fixer in a expected case.

Which issue, if any, is this issue related to?

Fixes #3847

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@alexander-schranz alexander-schranz changed the title WIP: Fix value-keyword-case in scss list Fix value-keyword-case in scss list Apr 11, 2019
hudochenkov
hudochenkov approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

jeddy3
jeddy3 approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-schranz Thanks for your contribution!

@jeddy3 jeddy3 merged commit 9b76cec into stylelint:master Apr 13, 2019
@jeddy3
Copy link
Member

jeddy3 commented Apr 13, 2019

  • Fixed: value-keyword-case autofix for single-line comments within maps (#4019).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix autofix for single-line comment within maps in value-keyword-case
3 participants
@alexander-schranz @jeddy3 @hudochenkov