Fix autofix for single-line comments within maps in value-keyword-case (

#4019)
stylelint · Apr 13, 2019 · 9b76cec · 9b76cec
1 parent 49fa75f
commit 9b76cec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/value-keyword-case/__tests__/index.js b/lib/rules/value-keyword-case/__tests__/index.js
@@ -691,6 +691,10 @@ testRule(rule, {
       code: "a { width: 1em; \n// display: BLOCK\n }",
       description: "ignore unit within comments"
     },
+    {
+      code: '$list: (\n key: "vAluE", // single quote comment\n );',
+      description: "ignore list single quote comment"
+    },
     {
       code: "a { $display: block; }"
     },

diff --git a/lib/rules/value-keyword-case/index.js b/lib/rules/value-keyword-case/index.js
@@ -59,6 +59,8 @@ const rule = function(expectation, options, context) {
         decl.raws.value ? decl.raws.value.raw : decl.value
       );
 
+      let needFix = false;
+
       parsed.walk(node => {
         const valueLowerCase = node.value.toLowerCase();
 
@@ -210,6 +212,7 @@ const rule = function(expectation, options, context) {
         }
 
         if (context.fix) {
+          needFix = true;
           node.value = expectedKeyword;
 
           return;
@@ -224,7 +227,7 @@ const rule = function(expectation, options, context) {
         });
       });
 
-      if (context.fix) {
+      if (context.fix && needFix) {
         decl.value = parsed.toString();
       }
     });