Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for flush comments containing a comma in selector-max-universal #3817

Merged
merged 5 commits into from
Jan 10, 2019
Merged

Fix false positives for flush comments containing a comma in selector-max-universal #3817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e9e1cc
Fix false positives for final newlines in max-empty-lines
sswebcoder Nov 7, 2018
34d9d85
Merge remote-tracking branch 'upstream/master'
sswebcoder Nov 8, 2018
7164b65
Merge remote-tracking branch 'upstream/master'
sswebcoder Nov 13, 2018
3b221da
selector-max-universal. Comment parsing was fixed.
sswebcoder Nov 22, 2018
b6e9bb6
Codestyle fix.
sswebcoder Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/rules/selector-max-universal/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ testRule(rule, {
{
code: "foo .bar {}"
},
{
code: ".foo,/* .class, */.bar {}"
},
{
code: "#foo {}"
},
Expand Down
17 changes: 16 additions & 1 deletion lib/rules/selector-max-universal/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const parseSelector = require("../../utils/parseSelector");
const report = require("../../utils/report");
const resolvedNestedSelector = require("postcss-resolve-nested-selector");
const ruleMessages = require("../../utils/ruleMessages");
const selectorParser = require("postcss-selector-parser");
const validateOptions = require("../../utils/validateOptions");

const ruleName = "selector-max-universal";
Expand Down Expand Up @@ -75,7 +76,21 @@ function rule(max) {
return;
}

ruleNode.selectors.forEach(selector => {
const selectors = [];

selectorParser()
.astSync(ruleNode.selector)
.walk(node => {
if (node.type === "selector") {
selectors.push(
String(node)
.replace(/^(\s*)/m, "")
.replace(/(\s*)$/m, "")
);
}
});

selectors.forEach(selector => {
resolvedNestedSelector(selector, ruleNode).forEach(resolvedSelector => {
parseSelector(resolvedSelector, result, ruleNode, container =>
checkSelector(container, ruleNode)
Expand Down