Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for flush comments containing a comma in selector-max-universal #3817

Merged
merged 5 commits into from Jan 10, 2019
Merged

Fix false positives for flush comments containing a comma in selector-max-universal #3817

merged 5 commits into from Jan 10, 2019

Conversation

sswebcoder
Copy link
Member

Fix for #3729

@ntwb
Copy link
Member

ntwb commented Nov 27, 2018

A couple of ESLint errors need resolving, otherwises tests are passing:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-universal/index.js
   3:1  error  This group of requires is not sorted       sort-requires/sort-requires
  80:7  error  Expected blank line before this statement  padding-line-between-statements

@jeddy3 jeddy3 changed the title Fix for parsing comment in selector for 'selector-max-universal' Fix false positives for flush comments containing a comma in selector-max-universal Nov 27, 2018
@sswebcoder
Copy link
Member Author

A couple of ESLint errors need resolving, otherwises tests are passing:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-universal/index.js
   3:1  error  This group of requires is not sorted       sort-requires/sort-requires
  80:7  error  Expected blank line before this statement  padding-line-between-statements

Linter errors was fixed.
Should I do something else?

jeddy3
jeddy3 approved these changes Dec 27, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Does anyone have the time to provide a second review on this?

hudochenkov
hudochenkov approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@hudochenkov hudochenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hudochenkov hudochenkov merged commit 584876d into stylelint:master Jan 10, 2019
@hudochenkov
Copy link
Member

  • Fixed: false positives for flush comments containing a comma in selector-max-universal (#3817).

@hudochenkov hudochenkov mentioned this pull request Jan 10, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudochenkov hudochenkov hudochenkov approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sswebcoder @ntwb @hudochenkov @jeddy3