Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baseIndentLevel to indentation #3557

Merged
merged 1 commit into from Sep 6, 2018
Merged

Add baseIndentLevel to indentation #3557

merged 1 commit into from Sep 6, 2018

Conversation

gucong3000
Copy link
Member

Which issue, if any, is this issue related to?

Closes #3427

Is there anything in the PR that needs further explanation?

Add setting baseIndentLevel for indentation rule. See: lib/rules/indentation/README.md

jeddy3
jeddy3 approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Any objections to this going in?

ntwb
ntwb approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, no objections from I

@jeddy3 jeddy3 changed the title Add support for relative or infer indent level in CSS blocks Add baseIndentLevel to indentation Sep 6, 2018
@jeddy3 jeddy3 merged commit 0c48541 into master Sep 6, 2018
@jeddy3 jeddy3 deleted the indent_infer branch September 6, 2018 16:17
@jeddy3
Copy link
Member

jeddy3 commented Sep 6, 2018

  • Added: baseIndentLevel to indentation (#3557).

This was referenced Sep 27, 2018
Merged
Merged
@hudochenkov hudochenkov mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

@ntwb ntwb ntwb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indentation rule
3 participants
@gucong3000 @jeddy3 @ntwb