Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReDoS issue (#5128) #5539

Merged
merged 1 commit into from Sep 15, 2021
Merged

Fix ReDoS issue (#5128) #5539

merged 1 commit into from Sep 15, 2021

Conversation

hudochenkov
Copy link
Member

Which issue, if any, is this issue related to?

Fixes #5128.

Is there anything in the PR that needs further explanation?

RegExp in question was added in #3557 for baseIndentLevel and it is only for HTML and CSS-in-JS files. Since we don't support these syntaxes and tests are skipped, no tests are failing :)

In fact we have no running tests for baseIndentLevel.

@hudochenkov
Copy link
Member Author

Screen Shot 2021-09-15 at 18 13 13

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM! 👏🏼

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomesauce, thanks!

@jeddy3 jeddy3 merged commit 92e5068 into v14 Sep 15, 2021
@jeddy3 jeddy3 deleted the fix-redos-warning branch September 15, 2021 16:28
@jeddy3
Copy link
Member

jeddy3 commented Sep 15, 2021

  • Security: addressed ReDoS issue with regex in indentation (#5539).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants