Add color-function-notation #4760
Conversation
There was a problem hiding this comment.
Not the most experienced dev on the topic, but I will say the test cases seem reasonably expansive: testing different combinations of units, using calc and CSS variables, and testing rgb, rgba, hsl, and hsla. Documentation also seems expressive enough.
Gets a LGTM from me! 👍
|
@malsf21 Thank you for the review!
With the bugs that you've been squashing, you have more familiarity with stylelint than most! We're a small group of contributors, and so any help makes an impact and is appreciated (whether that's squashing bugs, reviewing pull requests or triaging issues!). Let's merge this pull request after we release |
|
Changelog:
|
Closes #4718
I thought I'd give this one a whirl as it's been a while since I wrote a rule.
The
"modern"option is autofixable, and I've addressed the edge-cases I can think of.There may be a neater way to write the fixing code that doesn't rely on a count.