Add ErrorObject to StripeError exceptions #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-error
branch
2 times, most recently
from
74a5099
to
08567c3
Compare
|
Ugh there's a circular import issue. Will fix. |
remi-stripe
reviewed
Sep 24, 2019
|
Circular import should be fixed, ptal @remi-stripe. |
remi-stripe
approved these changes
Sep 25, 2019
| z.update(y) | ||
| return z | ||
|
|
||
|
|
There was a problem hiding this comment.
How is that not a helper function in Python already 🙀
| assert err.error is not None | ||
| assert err.error.code == "some_error" | ||
| assert err.error.charge is None | ||
|
|
There was a problem hiding this comment.
Is it worth adding tests for all 7 params in case we break something?
|
Released as 2.37.0. |
thieman
reviewed
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries
Similar to stripe/stripe-ruby#811 and stripe/stripe-php#705.