Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that error is a dict before trying to use it to create a StripeError #620

Merged
merged 1 commit into from Sep 26, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Check that error in the JSON data is a dict before trying to use it to initialize the StripeError instance. (This should never happen in production, but can happen in unit tests where StripeErrors are manually constructed.)

Addresses this comment from @thieman: #619 (comment)

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Sep 26, 2019
@ob-stripe ob-stripe merged commit 57ff0f8 into master Sep 26, 2019
@ob-stripe ob-stripe deleted the ob-error-object-check-type branch September 26, 2019 18:38
@ob-stripe
Copy link
Contributor Author

Released as 2.37.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants