Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update afterpay/clearpay to support FR and ES. #5221
Update afterpay/clearpay to support FR and ES. #5221
Changes from 6 commits
a2cd70c
e234927
71aaad0
3c415dd
25940b4
c4d324f
b294f15
1553ad3
1ea81b2
7aa2be1
8bf3b59
35eee61
e94636b
5a74a25
9d5207b
4cdac38
355b295
2eb7fd4
81ea5e1
dcfefcd
689db6a
3d777ba
f42a527
455f2c6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have enums for currency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, currently we don't. There is a java.util.Currency class that we could use to get strongly typed currencies. Right now I can see it being good to strongly type the currency in the Amount.kt, CurrencyFormatter. Not sure there is a lot of value in adding it for the older classes.
Given the size of this type of change I would recommend pulling it out as a tech debt item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The afterpay image is bottom aligned, whereas the affirm one is "aboveBaseline"