Update afterpay/clearpay to support FR and ES. #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al vs the new one.
michelleb-stripe
requested review from
brnunes-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
payments-ui-core/src/main/java/com/stripe/android/ui/core/elements/AfterpayClearpayElementUI.kt
Outdated
Show resolved
Hide resolved
| urlSpanStyle: SpanStyle = SpanStyle(textDecoration = TextDecoration.Underline) | ||
| enabled: Boolean = true, | ||
| urlSpanStyle: SpanStyle = SpanStyle(textDecoration = TextDecoration.Underline), | ||
| imageAlign: PlaceholderVerticalAlign = PlaceholderVerticalAlign.AboveBaseline |
There was a problem hiding this comment.
The afterpay image is bottom aligned, whereas the affirm one is "aboveBaseline"
|
Diffuse output: APKDEXARSC |
michelleb-stripe
requested review from
carlosmuvi-stripe and
ccen-stripe
as code owners
michelleb-stripe
changed the title
michelleb-stripe
assigned skyler-stripe, jameswoo-stripe and michelleb-stripe and unassigned brnunes-stripe, skyler-stripe and jameswoo-stripe
| amount.currencyCode | ||
| fun getLabel(resources: Resources): String { | ||
| val numInstallments = when (amount.currencyCode.lowercase()) { | ||
| "eur" -> 3 |
There was a problem hiding this comment.
Do we have enums for currency?
There was a problem hiding this comment.
No, currently we don't. There is a java.util.Currency class that we could use to get strongly typed currencies. Right now I can see it being good to strongly type the currency in the Amount.kt, CurrencyFormatter. Not sure there is a lot of value in adding it for the older classes.
Given the size of this type of change I would recommend pulling it out as a tech debt item.
| @@ -13,15 +14,35 @@ import java.util.Locale | |||
| class AfterpayClearpayHeaderElementTest { | |||
|
|
|||
| @Test | |||
| fun `Verify label is correct`() { | |||
| fun `Verify label is correct for USD`() { | |||
There was a problem hiding this comment.
Can we add a test for image first? As in one of the images you posted in the PR description
There was a problem hiding this comment.
We can't do this on the main sheet because the order of the LPMs in the selectors is not consistent. As we advance our screenshot testing I think it would be good to add testing for the core UI components like the Html element rather than the payment method specific UI.
There was a problem hiding this comment.
I am not really following. Can't we change the locale to korean or something that makes the image icon tag first in the string? Not looking for a screenshot test, an assert as you have in this test would suffice
michelleb-stripe
assigned jameswoo-stripe and unassigned brnunes-stripe, skyler-stripe and jameswoo-stripe
jameswoo-stripe
previously approved these changes
Jul 5, 2022
jameswoo-stripe
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update afterpay/clearpay to support new countries. A lot of these updates were to the Html element. This is so that clickable links would work correctly when they appeared after a Placeholder image.
Motivation
Request from platform team.
Testing
Screenshots
All screenshots with two messaging are showing the new messaging view with the original messaging view under it.
Changelog