Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy button front #2552

Merged
merged 23 commits into from Jan 6, 2021
Merged

Deploy button front #2552

merged 23 commits into from Jan 6, 2021

Conversation

arraydude
Copy link
Contributor

@arraydude arraydude commented Jan 5, 2021 •
edited

@arraydude arraydude requested a review from a team January 5, 2021 17:04
akrolsmir
akrolsmir approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So excited to land this and get it in front of our users~

lib/streamlit/report_session.py
@@ -428,11 +428,11 @@ def handle_git_information_request(self):
msg.git_info_changed.state = GitInfo.GitStates.AHEAD_OF_REMOTE
else:
msg.git_info_changed.state = GitInfo.GitStates.DEFAULT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like before, we would always send an empty ForwardMsg even if something failed in our Git import; now, we don't send that ForwardMsg.

Just wanted to check -- was this change on purpose, and is it necessary? Since the rest of the PR is just frontend code, ideally we don't have to change the Python code here; but eg if this is needed for our logic to be correct, or a test to pass here, I'm okay with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing a test due to this because we've been sending an empty forwardmsg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do a separate PR for this?

@arraydude arraydude merged commit 0f66b6e into streamlit:develop Jan 6, 2021
@arraydude arraydude deleted the deploy-button-front branch January 6, 2021 14:51
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 11, 2021
@tconkling
Merge branch 'develop' into tim/FormProto
0c2d488 
* develop: (21 commits)
  Remove depressing emojis (streamlit#2565)
  Go back to v1 metrics. (streamlit#2572)
  Up version to 0.74.1
  Revert "Upgrade react-hotkeys (streamlit#2525)"
  Revert "Upgrade react-markdown (streamlit#2527)"
  Revert "Revert "Deploy button py (streamlit#2535)""
  Revert "Deploy button py (streamlit#2535)"
  Update change log
  Update notices
  Up version to 0.74.0
  Update instructions placement on number input (streamlit#2549)
  Fix broken url (streamlit#2540)
  Deploy button front (streamlit#2552)
  Bump camelcase from 5.3.1 to 6.2.0 in /frontend (streamlit#2558)
  Fix block-container styles for sidebar (streamlit#2551)
  Bump @types/lodash from 4.14.165 to 4.14.167 in /frontend (streamlit#2550)
  Bump axios from 0.19.2 to 0.21.1 in /frontend (streamlit#2548)
  Remove deprecation message + add config expiration (streamlit#2546)
  Deploy button py (streamlit#2535)
  Remove aws-sdk (streamlit#2545)
  ...
tvst added a commit to tvst/streamlit that referenced this pull request Jan 14, 2021
@tvst
Revert "Deploy button front (streamlit#2552)"
ea3e718 
This reverts commit 0f66b6e.
tvst added a commit that referenced this pull request Jan 14, 2021
@tvst @karriebear
Revert "Deploy button front (#2552)" (#2599)
5e557ab 
* Revert "Deploy button front (#2552)"

This reverts commit 0f66b6e.

* Fix merge (erm... revert) conflict.

* Revert "Deploy button py (#2535)"

This reverts commit 0bbc7aa.

Co-authored-by: karrie <karrie@streamlit.io>
@akrolsmir akrolsmir mentioned this pull request Jan 19, 2021
Closed
tconkling added a commit to tconkling/streamlit that referenced this pull request Jan 19, 2021
@tconkling
Merge branch 'develop' into tim/FormProto
2a54c20 
* develop:
  Feature/sudoless metrics (streamlit#2605)
  Have st.number_input warn user of mismatched type and format string (streamlit#2604)
  Remove extra period from sentence (streamlit#2601)
  Revert "Deploy button front (streamlit#2552)" (streamlit#2599)
  Fix slider UX (streamlit#2596)
CFrez pushed a commit to CFrez/streamlit that referenced this pull request Jan 21, 2021
@tvst @karriebear @CFrez
Revert "Deploy button front (streamlit#2552)" (streamlit#2599)
10d36be 
* Revert "Deploy button front (streamlit#2552)"

This reverts commit 0f66b6e.

* Fix merge (erm... revert) conflict.

* Revert "Deploy button py (streamlit#2535)"

This reverts commit 0bbc7aa.

Co-authored-by: karrie <karrie@streamlit.io>
kmcgrady pushed a commit that referenced this pull request Jan 25, 2021
@CFrez @karriebear
@tvst @vdonato @AnOctopus @akrolsmir
Switched react-katex package (#2619)
2152e2a 
* switched react-katex package

* lockfile updated

* update test to corrected spelling

* decapitalize KaTex

* Fix slider UX (#2596)

* Fix slider UX

* Add snapshot

* Revert "Deploy button front (#2552)" (#2599)

* Revert "Deploy button front (#2552)"

This reverts commit 0f66b6e.

* Fix merge (erm... revert) conflict.

* Revert "Deploy button py (#2535)"

This reverts commit 0bbc7aa.

Co-authored-by: karrie <karrie@streamlit.io>

* Remove extra period from sentence (#2601)

* Have st.number_input warn user of mismatched type and format string (#2604)

* Add %u to list of valid number_input formatters

* Have number_input warn user of mismatched type and format string

* Use more modern f-string syntax instead of .format()

* Feature/sudoless metrics (#2605)

* Add and use sudoless machine id getter for metrics

Step 2 of the metrics user ID improvement plan.

* Add machine-id v3 tests

Duplicates of the v1 tests, since those covered the cases that remain in v3,
and we will remove v1 and its tests later.

Also fix formatting of some python files.

* DRY out machine ID paths into global constants

* Increase side padding to 5rem when app is in wide mode (#2613)

* Increase side padding to 5rem when app is in wide mode

* Upload Cypress snapshot

* Rerender Maybe components when they're first disabled (#2617)

\#2395 ended up being caused by this since we don't rerender placeholder
components created by `st.empty()` when react props/state change as a
performance optimization, but we need to do so when replacing an
existing component with an empty one to get rid of what's currently
drawn on screen.

Closes #2395

Co-authored-by: karrie <karrie@streamlit.io>
Co-authored-by: Thiago Teixeira <thiago@streamlit.io>
Co-authored-by: Randy Zwitch <randy@streamlit.io>
Co-authored-by: Vincent Donato <vincent.rdonato@gmail.com>
Co-authored-by: Amanda Walker <amanda@amandawalker.io>
Co-authored-by: Austin Chen <akrolsmir@gmail.com>
Co-authored-by: Vincent Donato <vincent@streamlit.io>
kmcgrady pushed a commit to kmcgrady/streamlit that referenced this pull request Mar 19, 2021
@arraydude
Deploy button front (streamlit#2552)
b078e63 
* Python side

* format

* import

* todo

* #  * git binary or GitPython not installed

* undo white spaces

* undo white spaces

* undo white spaces

* handle_git_information_request

* git_info_changed

* Using enum

* ahead_commits and uncommitted_files as properties

* format

* Frontend changes

* Working with frontend changes

* Deprecating deployParams

* Unit tests working

* deploy

* snapshots

* Fixing spec, and updating snapshot

* Fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrolsmir akrolsmir akrolsmir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arraydude @akrolsmir