Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy button front #2552

Merged
merged 23 commits into from
Jan 6, 2021
Merged

Deploy button front #2552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
346fd15
Python side
arraydude Dec 29, 2020
9f83d30
format
arraydude Dec 29, 2020
06e8967
import
arraydude Dec 29, 2020
00dc9d1
todo
arraydude Dec 29, 2020
aabd1cc
# * git binary or GitPython not installed
arraydude Dec 29, 2020
6575668
undo white spaces
arraydude Dec 29, 2020
92d2a7a
undo white spaces
arraydude Dec 29, 2020
31c40d2
undo white spaces
arraydude Dec 29, 2020
e5a0bda
handle_git_information_request
arraydude Dec 29, 2020
9edc9cd
git_info_changed
arraydude Dec 29, 2020
778009e
Using enum
arraydude Dec 30, 2020
bf22d56
ahead_commits and uncommitted_files as properties
arraydude Dec 30, 2020
7d7a12c
format
arraydude Dec 30, 2020
fd36d53
Frontend changes
arraydude Dec 31, 2020
67a9404
Working with frontend changes
arraydude Dec 31, 2020
8639249
Deprecating deployParams
arraydude Dec 31, 2020
79fd0c3
Unit tests working
arraydude Dec 31, 2020
5267906
Merge branch 'develop' of https://github.com/streamlit/streamlit into…
arraydude Jan 5, 2021
f711966
deploy
arraydude Jan 5, 2021
12c8a2a
snapshots
arraydude Jan 5, 2021
d05e85d
Fixing spec, and updating snapshot
arraydude Jan 5, 2021
4f8e4c3
Merge branch 'develop' of https://github.com/streamlit/streamlit into…
arraydude Jan 5, 2021
3c8e641
Fixing test
arraydude Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/specs/st_main_menu.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe("main menu", () => {
cy.get('[data-testid="main-menu-popover"]').invoke(
"attr",
"style",
"transform: translate3d(20px, 20px, 0px);z-index:99999;"
"transform: translate3d(20px, 20px, 0px);"
);
cy.get('[data-testid="main-menu-list"]').matchImageSnapshot("main_menu");

Expand Down
4 changes: 2 additions & 2 deletions lib/streamlit/report_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,11 +428,11 @@ def handle_git_information_request(self):
msg.git_info_changed.state = GitInfo.GitStates.AHEAD_OF_REMOTE
else:
msg.git_info_changed.state = GitInfo.GitStates.DEFAULT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like before, we would always send an empty ForwardMsg even if something failed in our Git import; now, we don't send that ForwardMsg.

Just wanted to check -- was this change on purpose, and is it necessary? Since the rest of the PR is just frontend code, ideally we don't have to change the Python code here; but eg if this is needed for our logic to be correct, or a test to pass here, I'm okay with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing a test due to this because we've been sending an empty forwardmsg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do a separate PR for this?

self.enqueue(msg)
except:
pass

self.enqueue(msg)

def handle_rerun_script_request(self, client_state=None, is_preheat=False):
"""Tell the ScriptRunner to re-run its report.

Expand Down