Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving deploy button experience #2422

Closed
wants to merge 49 commits into from

Conversation

arraydude
Copy link
Contributor

Issue: https://www.notion.so/streamlit/Improve-Core-deploy-button-experience-134acf45228e4ff0a39ede92a9ecc81a

Description:

  • Adding more repository information to the initial message
  • New backMsg which reloads and resends the initial information without rerunning the script
  • New modals for each different scenario specified in the Notion document

Screen Shot 2020-12-04 at 6 35 20 PM

Screen Shot 2020-12-04 at 6 30 38 PM

Screen Shot 2020-12-04 at 6 30 58 PM

Screen Shot 2020-12-04 at 6 31 27 PM

Screen Shot 2020-12-04 at 6 32 44 PM

Screen Shot 2020-12-04 at 6 33 41 PM


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@arraydude arraydude requested a review from a team December 4, 2020 23:38
@arraydude arraydude changed the title Improving deploy button experience WIP: Improving deploy button experience Dec 7, 2020
@karriebear karriebear marked this pull request as draft December 7, 2020 22:00
@karriebear karriebear requested review from kmcgrady and removed request for karriebear December 7, 2020 22:05
Copy link
Contributor

@randyzwitch randyzwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear to me where I'm a code owner, but I'll approve since Ken appears to be giving this a detailed lookover

@tvst
Copy link
Contributor

tvst commented Dec 11, 2020

I installed the latest wheel file from @arraydude and this still doesn't work. Here's what I see in the logs:

$ streamlit run streamlit_app.py
=== git path streamlit_app.py
=== git path /media/storage/Projects/streamlit/test_app/streamlit_app.py
=== git version (2, 28, 0)
=== git is minimum
=== git version (2, 28, 0)
=== git is minimum
=== git repo <git.repo.base.Repo '/media/storage/Projects/streamlit/test_app/.git'>

  You can now view your Streamlit app in your browser.

  Local URL: http://localhost:8501
  Network URL: http://192.168.1.253:8501

=== git repo <git.repo.base.Repo '/media/storage/Projects/streamlit/test_app/.git'>
=== repo <streamlit.git_util.GitRepo object at 0x7f147cda9550>
=== info None
=== detached False
=== untracked ['Pipfile', 'secrets.py']
=== uncommitted []
=== debugg []
=== ahead False


CLICKED ON "DEPLOY" MENU ITEM:
(no new logs)

CLICKED ON "TRY AGAIN":
=== git path /media/storage/Projects/streamlit/test_app/streamlit_app.py
=== git version (2, 28, 0)
=== git is minimum
=== git repo <git.repo.base.Repo '/media/storage/Projects/streamlit/test_app/.git'>
=== repo <streamlit.git_util.GitRepo object at 0x7f147ccc9160>
=== info None
=== detached False
=== untracked ['Pipfile', 'secrets.py']
=== uncommitted []
=== debugg []
=== ahead False

You can repro by downloading the wheel file from Emiliano and then creating this Dockerfile on that same folder:

FROM python:3.7-slim

WORKDIR /home

ADD streamlit-0.72.0-py2.py3-none-any.whl .
RUN pip install streamlit-0.72.0-py2.py3-none-any.whl

RUN apt update && apt-get install -y git && rm -rf /var/lib/apt/lists/*

RUN echo '\n\
import streamlit as st\n\
st.write("hello")\n\
' > streamlit_app.py

RUN git config --global user.email "demo@streamlit.io"
RUN git config --global user.name "Demo User"

RUN git init
RUN git add streamlit_app.py
RUN git commit -m "First commit"

CMD ["streamlit", "run", "streamlit_app.py"]

Then just call this as usual:

docker build --tag=testapp:1 .
docker run -p 8501:8501 testapp:1

if not self.is_valid():
return None

return [item.a_path for item in self.repo.index.diff(None)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on this comment.

lib/streamlit/git_util.py Outdated Show resolved Hide resolved
lib/streamlit/report_session.py Outdated Show resolved Hide resolved
@@ -423,6 +447,10 @@ def _enqueue_report_finished_message(self, status):
msg.report_finished = status
self.enqueue(msg)

def handle_reload_report_message(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I understand why you would be doing that. I just want to make sure that's what we should do. I'll circle back here.

This was referenced Dec 29, 2020
@akrolsmir
Copy link
Contributor

Closing this since we've moved forward with #2552 and #2535 ~

@akrolsmir akrolsmir closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants