-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving deploy button experience #2422
Conversation
… deploy-button # Conflicts: # frontend/src/components/core/MainMenu/MainMenu.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear to me where I'm a code owner, but I'll approve since Ken appears to be giving this a detailed lookover
I installed the latest wheel file from @arraydude and this still doesn't work. Here's what I see in the logs:
You can repro by downloading the wheel file from Emiliano and then creating this Dockerfile on that same folder:
Then just call this as usual:
|
if not self.is_valid(): | ||
return None | ||
|
||
return [item.a_path for item in self.repo.index.diff(None)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on this comment.
lib/streamlit/report_session.py
Outdated
@@ -423,6 +447,10 @@ def _enqueue_report_finished_message(self, status): | |||
msg.report_finished = status | |||
self.enqueue(msg) | |||
|
|||
def handle_reload_report_message(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I understand why you would be doing that. I just want to make sure that's what we should do. I'll circle back here.
… deploy-button # Conflicts: # lib/streamlit/elements/data_frame_proto.py # lib/streamlit/elements/time_widgets.py # lib/streamlit/elements/vega_lite.py # lib/streamlit/elements/write.py
Deprecating deployParams from initialMessage and adding a new one
Issue: https://www.notion.so/streamlit/Improve-Core-deploy-button-experience-134acf45228e4ff0a39ede92a9ecc81a
Description:
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.