tests: fix Accept-Encoding headers in stream_json #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
force-pushed
the
tests/requests-accept-encoding
branch
from
aa284d7
to
ae747a1
Compare
back-to
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
sidenote: tests will fail with lower requests version
it is set requests>=2.26.0 so it might be okay.
https://github.com/streamlink/streamlink/blob/master/setup.py#L13
|
If someone installs/packages streamlink with invalid dependencies, then this is not our problem. |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Sep 16, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4021
requests
2.26.0:psf/requests@5351469