Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlink: patch tests for compatibility with Requests 2.26 #138201

Merged
merged 1 commit into from
Sep 18, 2021

Conversation

DeeUnderscore
Copy link
Contributor

Motivation for this change

Fails to build currently: https://hydra.nixos.org/build/153000251

Applying upstream patch from streamlink/streamlink#4022

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 138201 at 299d4d7 run on x86_64-linux 1

2 packages built successfully:
  • streamlink
  • streamlink-twitch-gui-bin

@bobby285271
Copy link
Member

Result of nixpkgs-review pr 138201 run on x86_64-linux 1

2 packages built:
  • streamlink
  • streamlink-twitch-gui-bin

@bobby285271 bobby285271 merged commit 2c2a20a into NixOS:master Sep 18, 2021
@DeeUnderscore DeeUnderscore deleted the streamlink-patch-tests branch September 18, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants