Fix marketplace data fetching #15447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 49.80% // Head: 65.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feature/market-pagination #15447 +/- ##
==============================================================
+ Coverage 49.80% 65.11% +15.31%
==============================================================
Files 290 1064 +774
Lines 10184 22947 +12763
Branches 2252 4084 +1832
==============================================================
+ Hits 5072 14942 +9870
- Misses 4214 7055 +2841
- Partials 898 950 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markkaylor
approved these changes
Jan 16, 2023
Comment on lines
-12
to
-17
| // Only keep v4 plugins | ||
| const filteredResponse = { | ||
| ...response, | ||
| data: response.data.filter((plugin) => plugin.attributes.strapiCompatibility === 'v4'), | ||
| }; | ||
|
|
There was a problem hiding this comment.
Should we update the proxy now to remove strapiCompatibility?
There was a problem hiding this comment.
I don't think we can because it would break the previous versions of strapi apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
axios/axios#5113