Add pagination to marketplace #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
pr: enhancement
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #15457 +/- ##
===========================================
- Coverage 59.97% 47.61% -12.36%
===========================================
Files 1485 448 -1037
Lines 37488 15773 -21715
Branches 7523 3382 -4141
===========================================
- Hits 22482 7511 -14971
+ Misses 12797 6855 -5942
+ Partials 2209 1407 -802
Flags with carried forward coverage won't be shown. Click here to find out more. see 1263 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@remidej does this need further testing if it combines previously approved PRs, did the last PR merged contain all changes on this branch? |
|
@markkaylor all the code here should have been reviewed, I don't believe there was any commit on the feature branch directly. But I'd appreciate it if someone could manually test it really quick to be sure since it's targeting main |
markkaylor
previously approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Great work Rémi, this is awesome.
One small thing I noticed but I don't think it is a big deal. We don't seem to have an onBlur handler on the filter button. When you apply a filter and then click the search it would be nice if the filters closed. What do you think? If you agree I think we could go ahead and merge this and just create a ticket for that in the backlog.
Feranchz
force-pushed
the
feature/market-pagination
branch
from
54e7aff
to
578e41c
Compare
|
Size Change: +518 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
remidej
commented
Apr 11, 2023
markkaylor
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines previously approved PRs: #14935 #14911 #15006 #15420 #15447
What does it do?
Why is it needed?
With 100+ plugins on the marketplace, making unpaginated requests created performance problems.
How to test it?
Open /admin/marketplace and navigate from page to page. Try making searches too, and combining them with filters.