Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: use storyshot-puppeteer for things other than image snapshots #8934

Merged
merged 10 commits into from Nov 28, 2019
Merged

Feature: use storyshot-puppeteer for things other than image snapshots #8934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dfbb706
storyshots-puppeteer: introduce puppeteerTest and axeTest exports
Hypnosphi Nov 24, 2019
370285a
Add docs. Don't open story page is there are no tests defined in it
Hypnosphi Nov 24, 2019
05be6c9
Merge remote-tracking branch 'origin/next' into storyshot-puppeteer-g…
Hypnosphi Nov 24, 2019
9ee47eb
Add CI job
Hypnosphi Nov 24, 2019
4439243
Fix some of the a11y violations
Hypnosphi Nov 24, 2019
678c8b8
Merge branch 'fix-image-snapshot' into storyshot-puppeteer-generalisa…
Hypnosphi Nov 25, 2019
db5067e
Fix peerDependency
Hypnosphi Nov 25, 2019
eb59d19
Merge remote-tracking branch 'origin/next' into storyshot-puppeteer-g…
Hypnosphi Nov 28, 2019
ce59589
Merge remote-tracking branch 'origin/next' into storyshot-puppeteer-g…
Hypnosphi Nov 28, 2019
2b41cb5
Update storyshot
Hypnosphi Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/tests-puppeteer.yml
View file
Open in desktop
@@ -0,0 +1,32 @@
name: Puppeteer & A11y tests

on: [push]

jobs:
build:

name: Puppeteer & A11y tests
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v1
with:
node-version: '10.x'
- uses: actions/checkout@v1
- name: Cache node modules
uses: actions/cache@v1
with:
path: node_modules
key: ${{ runner.OS }}-build-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.OS }}-build-${{ env.cache-name }}-
${{ runner.OS }}-build-
${{ runner.OS }}-
- name: install, bootstrap
run: |
yarn bootstrap --core
- name: build storybook
run: |
yarn --cwd examples/official-storybook build-storybook
- name: test
run: |
yarn test --puppeteer
2 changes: 2 additions & 0 deletions addons/a11y/README.md
View file
Open in desktop
Expand Up @@ -47,6 +47,8 @@ export const inaccessible = () => (
);
```

## Parameters

For more customizability use parameters to configure [aXe options](https://github.com/dequelabs/axe-core/blob/develop/doc/API.md#api-name-axeconfigure).
You can override these options [at story level too](https://storybook.js.org/docs/configurations/options-parameter/#per-story-options).

Expand Down
6 changes: 6 additions & 0 deletions addons/a11y/src/components/__snapshots__/A11YPanel.test.js.snap
View file
Open in desktop
Expand Up @@ -952,6 +952,11 @@ exports[`A11YPanel should render report 1`] = `
>
<l
className="emotion-0"
scrollableNodeProps={
Object {
"tabIndex": 0,
}
}
>
<div
className="emotion-0"
Expand All @@ -975,6 +980,7 @@ exports[`A11YPanel should render report 1`] = `
>
<div
className="simplebar-content-wrapper"
tabIndex={0}
>
<div
className="simplebar-content"
Expand Down
24 changes: 24 additions & 0 deletions addons/info/src/__snapshots__/index.test.js.snap
View file
Open in desktop
Expand Up @@ -2627,6 +2627,11 @@ exports[`addon Info should render component description if story kind matches co
>
<l
className="emotion-2"
scrollableNodeProps={
Object {
"tabIndex": 0,
}
}
>
<div
className="emotion-2"
Expand All @@ -2650,6 +2655,7 @@ exports[`addon Info should render component description if story kind matches co
>
<div
className="simplebar-content-wrapper"
tabIndex={0}
>
<div
className="simplebar-content"
Expand Down Expand Up @@ -4412,6 +4418,11 @@ exports[`addon Info should render component description if story kind matches co
>
<l
className="emotion-2"
scrollableNodeProps={
Object {
"tabIndex": 0,
}
}
>
<div
className="emotion-2"
Expand All @@ -4435,6 +4446,7 @@ exports[`addon Info should render component description if story kind matches co
>
<div
className="simplebar-content-wrapper"
tabIndex={0}
>
<div
className="simplebar-content"
Expand Down Expand Up @@ -7416,6 +7428,11 @@ exports[`addon Info should render component description if story name matches co
>
<l
className="emotion-2"
scrollableNodeProps={
Object {
"tabIndex": 0,
}
}
>
<div
className="emotion-2"
Expand All @@ -7439,6 +7456,7 @@ exports[`addon Info should render component description if story name matches co
>
<div
className="simplebar-content-wrapper"
tabIndex={0}
>
<div
className="simplebar-content"
Expand Down Expand Up @@ -9429,6 +9447,11 @@ exports[`addon Info should render component description if story name matches co
>
<l
className="emotion-2"
scrollableNodeProps={
Object {
"tabIndex": 0,
}
}
>
<div
className="emotion-2"
Expand All @@ -9452,6 +9475,7 @@ exports[`addon Info should render component description if story name matches co
>
<div
className="simplebar-content-wrapper"
tabIndex={0}
>
<div
className="simplebar-content"
Expand Down
2 changes: 1 addition & 1 deletion addons/storyshots/README.md
View file
Open in desktop
@@ -1,4 +1,4 @@
# StoryShots

- [addon-storyshots](storyshots-core) - Basic StoryShots api
- [addon-storyshots-puppeteer](storyshots-puppeteer) - Image Snapshots addition to StoryShots based on [puppeteer](https://github.com/GoogleChrome/puppeteer)
- [addon-storyshots-puppeteer](storyshots-puppeteer) - Integration of StoryShots with [puppeteer](https://github.com/GoogleChrome/puppeteer)