Feature: use storyshot-puppeteer for things other than image snapshots #8934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
alterx,
igor-dv,
thomasbertet,
tmeasday and
usulpro
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
…eneralisation # Conflicts: # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json
Hypnosphi
force-pushed
the
storyshot-puppeteer-generalisation
branch
from
be12f76
to
9ee47eb
Compare
…eneralisation # Conflicts: # addons/a11y/README.md # addons/storyshots/storyshots-puppeteer/README.md # addons/storyshots/storyshots-puppeteer/package.json # addons/storyshots/storyshots-puppeteer/src/imageSnapshot.ts # examples/official-storybook/package.json # lib/api/src/version.ts
ndelangen
approved these changes
Nov 28, 2019
…eneralisation # Conflicts: # addons/a11y/README.md # addons/storyshots/storyshots-puppeteer/README.md # addons/storyshots/storyshots-puppeteer/package.json # addons/storyshots/storyshots-puppeteer/src/imageSnapshot.ts # examples/official-storybook/package.json # lib/api/src/version.ts
Hypnosphi
requested review from
dangreenisrael,
theinterned and
z4o4z
as code owners
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new exports to
@storybook/addon-storyshots-puppeteer:puppeteerTestfor arbitrary puppeteer tests andaxeTestfor AXE accessibility checksThis includes changes from #8932
TODO:
color-contrastfixes require a design review from @domyen: UI: some elements have too low color contrast #8935