Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-native-server: Changed default port to number in CLI options #8584

Merged
merged 1 commit into from Oct 27, 2019

Conversation

96f3e4c
Copy link
Contributor

@96f3e4c 96f3e4c commented Oct 27, 2019

Issue: related to #8487
While fixing the above issue in #8491 I accidentally introduces same bug for default port. This PR is a fix for that

What I did

Changed default port from string to number

@vercel
Copy link

vercel bot commented Oct 27, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@shilman shilman added react-native-server bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 27, 2019
@shilman shilman added this to the 5.2.x milestone Oct 27, 2019
@shilman shilman merged commit ba74d88 into storybookjs:next Oct 27, 2019
@96f3e4c 96f3e4c deleted the fix/rn-server-port-prompt branch October 27, 2019 12:14
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 9, 2019
shilman added a commit that referenced this pull request Nov 9, 2019
React-native-server: Changed default port to number in CLI options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants