Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary prompt for available port in react-native #8487

Closed
96f3e4c opened this issue Oct 20, 2019 · 4 comments
Closed

Unnecessary prompt for available port in react-native #8487

96f3e4c opened this issue Oct 20, 2019 · 4 comments

Comments

@96f3e4c
Copy link
Contributor

96f3e4c commented Oct 20, 2019

Describe the bug
When using storybook with react-native, yarn storybook which runs start-storybook -p 7007 prompting

Port 7007 is not available. Would you like to run Storybook on port 7007 instead?

To Reproduce
Steps to reproduce the behavior:

npx react-native init myapp
cd myapp
npx -p @storybook/cli sb init

 • Detecting project type. ✓
? Do you want to install dependencies necessary to run storybook server? You can manually do it later by install @storybook/react-native-server
Yes
...
yarn storybook

Expected behavior
If the specified port(ie: using the option -p for start-storybook) is available it should run without any prompt

Screenshots
20-Oct-Sun-2019-14:57:55-821x89

System:

    @storybook/addon-actions: ^5.2.4 => 5.2.4 
    @storybook/addon-links: ^5.2.4 => 5.2.4 
    @storybook/addons: ^5.2.4 => 5.2.4 
    @storybook/react-native: ^5.2.4 => 5.2.4 
    @storybook/react-native-server: ^5.2.4 => 5.2.4
@shilman
Copy link
Member

shilman commented Oct 22, 2019

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.5 containing PR #8491 that references this issue. Upgrade today to try it out!

@shilman
Copy link
Member

shilman commented Oct 22, 2019

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.24 containing PR #8491 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman
Copy link
Member

shilman commented Oct 27, 2019

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.32 containing PR #8584 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman
Copy link
Member

shilman commented Nov 9, 2019

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.6 containing PR #8584 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants