Added condition to check if it's an anchor link #8132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/buq0p3ctc |
victorgb6
changed the title
victorgb6
changed the title
victorgb6
requested review from
ndelangen,
tmeasday and
usulpro
as code owners
ndelangen
approved these changes
Oct 18, 2019
|
@shilman could you please take a peak at this? |
ndelangen
force-pushed
the
fix-addon-notes-anchor-links
branch
from
cd71311
to
a936d43
Compare
|
Thanks @ndelangen. Will kick the tires on it this weekend & get back! |
|
good to merge @shilman ? |
This was referenced Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8068 #8184
What I did
I checked that at Notes addon if you use an anchor link in markdown it's using the component to render and if you click on that link it's redirecting to another page instead of scrolling to the section. I added a regex to check if the link starts with # and used the normal tag to render instead the , same way if it's an absolute url.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.