Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Make anchor links work without being thrown into iframe.html #8068

Closed
jonathanloske opened this issue Sep 13, 2019 · 3 comments
Closed

Comments

@jonathanloske
Copy link

jonathanloske commented Sep 13, 2019

Is your feature request related to a problem? Please describe.
I created a rather long document (a changelog) and wanted to make navigation easier by providing anchor links. The anchor links work but they take me to the iframe.html version of the story I'm looking at.

Minimal example:

[Test](#a)

Describe the solution you'd like
I would like it so that clicks on an anchor link keep me on the current page and just scroll the content there.

Describe alternatives you've considered
I did not consider alternatives since the current behavior is not perfect but works.

Are you able to assist bring the feature to reality?
no

Additional context
This works as intended on the MDX playground so I guess this is an issue with Storybook.

@stale
Copy link

stale bot commented Oct 4, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 4, 2019
@shilman
Copy link
Member

shilman commented Oct 4, 2019

Closing this as a duplicate to #8184

@shilman
Copy link
Member

shilman commented Nov 15, 2019

Whoopee!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.46 containing PR #8132 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman shilman reopened this Nov 15, 2019
@stale stale bot removed the inactive label Nov 15, 2019
@shilman shilman closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants