CLI: Fix open in browser doesn't work in WSL #18305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, `x-default-browser` requires `xdg-utils` to be installed to determine a default browser. So it fails when it's not installed. However, in WSL, we still can open a browser without it. Now it fallbacks to `open` when `x-default-browser` fails which makes it work on WSL without `xdg-utils`.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eab88cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
added
bug
cli
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
May 24, 2022
CLI: Fix open in browser doesn't work in WSL
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18304
On Linux,
x-default-browserrequiresxdg-utilsto be installed to determine a default browser. So it fails when it's not installed. However, in WSL, we still can open a browser without it. Now it fallbacks toopenwhenx-default-browserfails which makes it work on WSL withoutxdg-utils.Tags: ["bug"]