Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in browser doesn't work in WSL when some system dependencies aren't installed #18304

Closed
lesha1201 opened this issue May 23, 2022 · 2 comments

Comments

@lesha1201
Copy link
Contributor

Describe the bug

Storybook uses x-default-browser for determing a default browser. On Linux, x-default-browser requires xdg-utils to be installed to determine it. It determines by running a command xdg-mime query default x-scheme-handler/http.

image

In case of WSL, we doesn't need to have xdg-utils to be installed to open in a browser. We still can open it in a browser without it.

However, we doesn't fallback when x-default-browser fails. I think we should fallback to open in this case.

image

@shilman
Copy link
Member

shilman commented May 24, 2022

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.5-alpha.3 containing PR #18305 that references this issue. Upgrade today to the @prerelease NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed May 24, 2022
@shilman
Copy link
Member

shilman commented May 24, 2022

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.5 containing PR #18305 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants