Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Fix 13.1 and add CI test cases #17206

Merged
merged 3 commits into from Jan 12, 2022
Merged

Angular: Fix 13.1 and add CI test cases #17206

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49982f6
fix(angular): fix ts build with angular 13.0
ThibaudAV Jan 11, 2022
fe9d7b0
ci(angular): add e2e test with angular 13.0 and 13.x
ThibaudAV Jan 11, 2022
ad72f05
fix(angular): fix sb init with angular 13
ThibaudAV Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Expand Up @@ -222,7 +222,7 @@ jobs:
# Do not test CRA here because it's done in PnP part
# TODO: Remove `web_components_typescript` as soon as Lit 2 stable is released
# TODO: Add `angular` as soon as Storybook is compatible with Angular 13
command: yarn test:e2e-framework vue3 angular12 angular11 web_components_typescript web_components_lit2
command: yarn test:e2e-framework vue3 angular130 angular13 angular12 angular11 web_components_typescript web_components_lit2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe remove the comment of L224, as angular13 == angular

no_output_timeout: 5m
- store_artifacts:
path: /tmp/cypress-record
Expand Down
12 changes: 12 additions & 0 deletions lib/cli/src/repro-generators/configs.ts
View file
Open in desktop
Expand Up @@ -117,6 +117,18 @@ export const angular12: Parameters = {
version: 'v12-lts',
};

export const angular130: Parameters = {
...baseAngular,
name: 'angular130',
version: '13.0.x',
};

export const angular13: Parameters = {
...baseAngular,
name: 'angular13',
version: '13.1.x',
};

export const angular: Parameters = baseAngular;
// #endregion

Expand Down