Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix 13.1 and add CI test cases #17206

Merged
merged 3 commits into from Jan 12, 2022
Merged

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Jan 11, 2022

Issue: #17201 #16977

What I did

Add e2e for angular 13.0.x and for 13.x.x
Fix issue with 13.0

  • first error with :
ModuleParseError: Module parse failed: Unexpected token (36:2)
File was processed with these loaders:
 * ./node_modules/@angular-devkit/build-angular/src/babel/webpack-loader.js
 * ./node_modules/@storybook/source-loader/dist/cjs/index.js
You may need an additional loader to handle the result of these loaders.
|     })
|   ]
> } as Meta;
|
| const template: Story<BadgeGroupComponent> = args => {
  • second error with bad tsConfig from legacy options fetch inside angular.json

  • And add allowSyntheticDefaultImports: true for angular generate to fix sb init for angular 13..x
    ✏️ I really think that all this part could be remade for Angular 13 with .ts config files, a clean tsconfig and use the default angular builder

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 11, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit ad72f05. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ThibaudAV ThibaudAV force-pushed the angular/fix-angular-13.1 branch 4 times, most recently from ccf3dc4 to 22fd49d Compare January 11, 2022 22:32
@ThibaudAV ThibaudAV changed the title Angular/fix angular 13.1 Angular: fix 13.0 Jan 11, 2022
@shilman shilman changed the title Angular: fix 13.0 Angular: Fix 13.1 Jan 12, 2022
@ThibaudAV ThibaudAV requested review from a team and gaetanmaisse January 12, 2022 08:40
@@ -222,7 +222,7 @@ jobs:
# Do not test CRA here because it's done in PnP part
# TODO: Remove `web_components_typescript` as soon as Lit 2 stable is released
# TODO: Add `angular` as soon as Storybook is compatible with Angular 13
command: yarn test:e2e-framework vue3 angular12 angular11 web_components_typescript web_components_lit2
command: yarn test:e2e-framework vue3 angular130 angular13 angular12 angular11 web_components_typescript web_components_lit2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe remove the comment of L224, as angular13 == angular

@shilman shilman changed the title Angular: Fix 13.1 Angular: Fix 13.1 and add CI test cases Jan 12, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging this @ThibaudAV 🙏

@shilman shilman merged commit 5fc5618 into next Jan 12, 2022
@shilman shilman deleted the angular/fix-angular-13.1 branch January 12, 2022 10:39
@Abinash-S
Copy link

Abinash-S commented Jan 12, 2022

I tried version 6.4.9 without the tilt "~" sign and it worked perfectly for me, but it does not work with version 6.4.10. It only works with version 6.4.9.

  "@storybook/addon-essentials": "6.4.9",
   "@storybook/angular": "6.4.9",
   "@storybook/builder-webpack5": "6.4.9",
   "@storybook/manager-webpack5": "6.4.9"

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Jan 14, 2022
shilman added a commit that referenced this pull request Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants