New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Add global CSF3 renderer #15742
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
81fe6de
add global CSF3 renderer for Angular
yngvebn 70823db
update compodoc snapshot
yngvebn ce1b4ec
improve naming of csf3 story
yngvebn 1ecfdea
fix: angular-properties.test.ts test
ThibaudAV 37bbe90
fix: disable storyshots for CSF3 sotry example
ThibaudAV File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
examples/angular-cli/src/stories/csf3/input-with-play.stories.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { screen } from '@testing-library/react'; | ||
import userEvent from '@testing-library/user-event'; | ||
import { InputComponent } from './sb-input.component'; | ||
|
||
export default { | ||
title: 'CSF3/Input', | ||
component: InputComponent, | ||
}; | ||
|
||
export const Default = { | ||
title: 'Default', | ||
play: async () => { | ||
const input = await screen.getByAltText('sb-input'); | ||
await userEvent.type(input, `Typing from CSF3`); | ||
}, | ||
}; | ||
|
||
export const WithTemplate = { | ||
title: 'Template', | ||
render: (props) => ({ | ||
props, | ||
template: '<h1>Heading</h1><sb-input></sb-input>', | ||
}), | ||
play: async () => { | ||
const input = await screen.getByAltText('sb-input'); | ||
await userEvent.type(input, `Typing from CSF3`); | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { Component } from '@angular/core'; | ||
|
||
@Component({ | ||
selector: 'sb-input', | ||
template: `<input type="text" alt="sb-input" />`, | ||
}) | ||
export class InputComponent {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
Core / CSF3 / Input
? OrBeta / ...
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would "Preview" be a fitting prefix perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..
so if CSF3 is to become something native in storybook main set, I can see it in
core/...
but it's up to you, knowing that ;)