Angular: Add global CSF3 renderer #15742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 37bbe90. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
|
@shilman / @ThibaudAV I'm struggling with getting the tests to run green locally, even though I haven't touched any of the files or tests it's complaining about... Would greatly appreciate if someone would help out.. The same goes for this PR: #15743 |
ThibaudAV
reviewed
Aug 3, 2021
| import { InputComponent } from './sb-input.component'; | ||
|
|
||
| export default { | ||
| title: 'CSF3/Input', |
There was a problem hiding this comment.
maybe Core / CSF3 / Input ? Or Beta / ... 🤔
There was a problem hiding this comment.
Would "Preview" be a fitting prefix perhaps?
There was a problem hiding this comment.
- In core I tried to place the stories showing and testing the native functionality of sotrybook
- basics it's more for examples of storybook use or helpers or common examples
- addons for addons
..
so if CSF3 is to become something native in storybook main set, I can see it incore/...
but it's up to you, knowing that ;)
yngvebn
changed the title
shilman
changed the title
shilman
approved these changes
Aug 7, 2021
You bet! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15498
What I did
Added a basic global renderer for Angular and CSF3
Enabled previewCsfV3 for the angular-cli example storybook
How to test
If your answer is yes to any of these, please make sure to include it in your PR.
Added a couple of stories to examples/angular-cli