Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix file-loader options for ESM compat #14480

Merged
merged 2 commits into from Apr 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/builder-webpack4/src/preview/base-webpack.config.ts
Expand Up @@ -110,6 +110,7 @@ export async function createDefaultWebpackConfig(
test: /\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\?.*)?$/,
loader: require.resolve('file-loader'),
options: {
esModule: false,
name: isProd
? 'static/media/[name].[contenthash:8].[ext]'
: 'static/media/[path][name].[ext]',
Expand Down
1 change: 1 addition & 0 deletions lib/builder-webpack5/src/preview/base-webpack.config.ts
Expand Up @@ -55,6 +55,7 @@ export async function createDefaultWebpackConfig(
test: /\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\?.*)?$/,
loader: require.resolve('file-loader'),
options: {
esModule: false,
name: isProd
? 'static/media/[name].[contenthash:8].[ext]'
: 'static/media/[path][name].[ext]',
Expand Down
Expand Up @@ -435,6 +435,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[path][name].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down
Expand Up @@ -434,6 +434,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[name].[contenthash:8].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down
1 change: 1 addition & 0 deletions lib/core-server/src/__snapshots__/vue-3-cli_preview-dev
Expand Up @@ -433,6 +433,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[path][name].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down
1 change: 1 addition & 0 deletions lib/core-server/src/__snapshots__/vue-3-cli_preview-prod
Expand Up @@ -432,6 +432,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[name].[contenthash:8].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down
Expand Up @@ -464,6 +464,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[path][name].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down
Expand Up @@ -463,6 +463,7 @@ Object {
Object {
"loader": "NODE_MODULES/file-loader/dist/cjs.js",
"options": Object {
"esModule": false,
"name": "static/media/[name].[contenthash:8].[ext]",
},
"test": "/\\\\.(svg|ico|jpg|jpeg|png|apng|gif|eot|otf|webp|ttf|woff|woff2|cur|ani|pdf)(\\\\?.*)?$/",
Expand Down