Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix file-loader options for ESM compat #14480

Merged
merged 2 commits into from
Apr 5, 2021
Merged

Core: Fix file-loader options for ESM compat #14480

merged 2 commits into from
Apr 5, 2021
+8 −0

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 5, 2021 •
edited by sync-by-unito bot
Loading

Issue: #3339

What I did

File-loader settings broke in 6.2. This fixes it.

How to test

See the "welcome" story in examples/vue-kitchen-sink. Somehow this got through! 🙈

┆Issue is synchronized with this Asana task by Unito

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2021 •
edited
Loading

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies","other"]

Generated by 🚫 dangerJS against 3f2ba78

@shilman shilman added this to the 6.2 stabilization milestone Apr 5, 2021
@shilman shilman merged commit bc37023 into next Apr 5, 2021
@shilman shilman deleted the 14423-fix-file-loader branch April 5, 2021 14:18
@shilman shilman mentioned this pull request Apr 5, 2021
Closed
@Niznikr Niznikr mentioned this pull request Apr 6, 2021
Closed
@christopher-francisco christopher-francisco mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug configuration babel / webpack core
Projects
None yet
Milestone
6.2 stabilization
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shilman