Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix not printing managerTotalTime when using cached manager #13294

Merged
merged 2 commits into from Nov 26, 2020
Merged

CLI: Fix not printing managerTotalTime when using cached manager #13294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8282be4
Make times and stats completely optional.
ghengeveld Nov 26, 2020
48437b7
Remove needless type casts.
ghengeveld Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions lib/core/src/server/build-dev.ts
View file
Open in desktop
Expand Up @@ -153,8 +153,8 @@ function outputStartupInformation(options: {
version: string;
address: string;
networkAddress: string;
managerTotalTime: [number, number];
previewTotalTime: [number, number];
managerTotalTime?: [number, number];
previewTotalTime?: [number, number];
}) {
const {
updateInfo,
Expand Down Expand Up @@ -283,10 +283,9 @@ export async function buildDevStandalone(

if (options.smokeTest) {
await outputStats(previewStats, managerStats);
const managerWarnings = (managerStats as any).toJson().warnings.length > 0;
const previewWarnings =
!options.ignorePreview && (previewStats as any).toJson().warnings.length > 0;
process.exit(managerWarnings || previewWarnings ? 1 : 0);
const hasManagerWarnings = managerStats && (managerStats as any).toJson().warnings.length > 0;
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
const hasPreviewWarnings = previewStats && (previewStats as any).toJson().warnings.length > 0;
process.exit(hasManagerWarnings || (hasPreviewWarnings && !options.ignorePreview) ? 1 : 0);
return;
}

Expand Down
4 changes: 2 additions & 2 deletions lib/core/src/server/dev-server.ts
View file
Open in desktop
Expand Up @@ -258,7 +258,7 @@ const startManager = async ({
}

if (!managerConfig) {
return { managerStats: null, managerTotalTime: [0, 0] } as ManagerResult;
return {} as ManagerResult;
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
}

const compiler = webpack(managerConfig);
Expand Down Expand Up @@ -311,7 +311,7 @@ const startPreview = async ({
outputDir,
}: any): Promise<PreviewResult> => {
if (options.ignorePreview) {
return { previewStats: null, previewTotalTime: [0, 0] } as PreviewResult;
return {} as PreviewResult;
ghengeveld marked this conversation as resolved.
Show resolved Hide resolved
}

const previewConfig = await loadConfig({
Expand Down
8 changes: 4 additions & 4 deletions lib/core/src/server/types.ts
View file
Open in desktop
Expand Up @@ -94,13 +94,13 @@ export interface ReleaseNotesData {
}

export interface PreviewResult {
previewStats: Stats;
previewTotalTime: [number, number];
previewStats?: Stats;
previewTotalTime?: [number, number];
}

export interface ManagerResult {
managerStats: Stats;
managerTotalTime: [number, number];
managerStats?: Stats;
managerTotalTime?: [number, number];
}

// TODO: this is a generic interface that we can share across multiple SB packages (like @storybook/cli)
Expand Down