Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix not printing managerTotalTime when using cached manager #13294

Merged
merged 2 commits into from Nov 26, 2020

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 26, 2020

Issue: #13292

What I did

I simply made this data optional, so it will be falsy again and thus not print the manager time. See issue for info.

Screenshot 2020-11-26 at 14 27 41

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld changed the title Fix not printing managerTotalTime when using cached manager CLI: Fix not printing managerTotalTime when using cached manager Nov 26, 2020
lib/core/src/server/build-dev.ts Outdated Show resolved Hide resolved
lib/core/src/server/dev-server.ts Outdated Show resolved Hide resolved
lib/core/src/server/dev-server.ts Outdated Show resolved Hide resolved
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman added this to the 6.1.x milestone Nov 26, 2020
@shilman shilman merged commit 9c35dcd into next Nov 26, 2020
@shilman shilman deleted the 13292-manager-time-label branch November 26, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants