Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-controls: Fix ensureDocsBeforeControls support for paths #13204

Merged
merged 1 commit into from Nov 24, 2020
Merged

Addon-controls: Fix ensureDocsBeforeControls support for paths #13204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/controls/src/preset/ensureDocsBeforeControls.test.ts
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@ describe.each([

describe.each([
[['@storybook/addon-docs', '@storybook/addon-controls']],
[['@storybook/addon-docs', 'foo/node_modules/@storybook/addon-controls']],
[[{ name: '@storybook/addon-docs' }, '@storybook/addon-controls']],
[['@storybook/addon-essentials', '@storybook/addon-controls']],
[['@storybook/addon-essentials']],
Expand Down
2 changes: 1 addition & 1 deletion addons/controls/src/preset/ensureDocsBeforeControls.ts
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@ type Entry = string | OptionsEntry;
const findIndex = (addon: string, addons: Entry[]) =>
addons.findIndex((entry) => {
const name = (entry as OptionsEntry).name || (entry as string);
return name && name.startsWith(addon);
return name && name.includes(addon);
});

const indexOfAddonOrEssentials = (addon: string, addons: Entry[]) => {
Expand Down