Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-controls: Fix ensureDocsBeforeControls support for paths #13204

Merged
merged 1 commit into from Nov 24, 2020

Conversation

jon301
Copy link
Contributor

@jon301 jon301 commented Nov 21, 2020

Issue: #13202

What I did

Ensuring Docs is before Controls or Essentials even if the latter resolves as a sub-package.

How to test

Run yarn jest ensureDocsBeforeControls

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 💯

@jon301
Copy link
Contributor Author

jon301 commented Nov 21, 2020

Thanks @shilman !
Is there something in particular to do to make the checks pass?

@shilman
Copy link
Member

shilman commented Nov 21, 2020

Don't worry about it 😅

@shilman shilman added this to the 6.1.x milestone Nov 24, 2020
@shilman shilman changed the title Addon-controls: Make ensureDocsBeforeControls support sub-dependencies Addon-controls: Make ensureDocsBeforeControls support paths Nov 24, 2020
@shilman shilman changed the title Addon-controls: Make ensureDocsBeforeControls support paths Addon-controls: Fix ensureDocsBeforeControls support for paths Nov 24, 2020
@shilman shilman merged commit 92e082f into storybookjs:next Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants