Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storyshots Puppeteer: Fix support for over 1 assertions in async tests #12657

Merged
merged 2 commits into from Oct 4, 2020
Merged

Storyshots Puppeteer: Fix support for over 1 assertions in async tests #12657

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfb1515
remove expect.assertions(1)
kahirokunn Oct 3, 2020
8401a48
expect >= 1 assertion in storyshots puppeteer test
kahirokunn Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion addons/storyshots/storyshots-puppeteer/src/imageSnapshot.ts
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@ export const imageSnapshot = (customConfig: Partial<ImageSnapshotConfig> = {}) =
return puppeteerTest({
...config,
async testBody(page, options) {
expect.assertions(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about expect.hasAssertions() instead? it seems like there's already an assertion being made, and this would ensure that there >= 1 assertion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good idea!

const element = await beforeScreenshot(page, options);
const image = await (element || page).screenshot(getScreenshotOptions(options));
await afterScreenshot({ image, context: options.context });
Expand Down