Storyshots Puppeteer: Fix support for over 1 assertions in async tests #12657
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahirokunn
changed the title
kahirokunn
changed the title
shilman
requested changes
Oct 3, 2020
| @@ -11,7 +11,6 @@ export const imageSnapshot = (customConfig: Partial<ImageSnapshotConfig> = {}) = | |||
| return puppeteerTest({ | |||
| ...config, | |||
| async testBody(page, options) { | |||
| expect.assertions(1); | |||
There was a problem hiding this comment.
WDYT about expect.hasAssertions() instead? it seems like there's already an assertion being made, and this would ensure that there >= 1 assertion.
There was a problem hiding this comment.
That's good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I wanna do more assertions in the test like this.
https://jestjs.io/docs/en/asynchronous#callbacks
maybe this assertions should be in the test code and not in the runtime code.