ArgsTable: Remove the "simple" detection for enum types #12587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Partial reversion of #11868
What I did
While working on a very large storybook, I noticed that a subset of types weren't formatted correctly. For example, they had no background. They were really standing out from the rest of the system. These types often looked like
(arg1: string) => 'return1' | 'return2'
.I traced it back to the
simple
option added in #11868 which added a check that is too simplistic for what it is trying to do. From what I understand, it was trying to avoid adding styling to complex unions, but it didn't consider a union-type value anywhere else in a signature.My suggestion is to remove this check for now until a more sophisticated check is applied.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.