New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-docs: Change the way PropType used by ArgTable are generated for Flow types #12589
Conversation
Seeing what looks like a formatting regression in this PR: Versus what I'm seeing in (NOTE: I updated this PR from @phated can you possibly:
Thanks and sorry for the slow slow response time on this 🙈 |
Very curious! There was no formatting when I originally worked on this. I probably need some time to investigate where that is being tripped up. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
closing this for now. please feel free to reopen if you need it! |
Issue: N/A
Requires: #12588
What I did
I changed the way Flow types were converted into
PropType
because ArgsTable expects a string forsummary
anddetails
, but Flow types passed to the converter will contain rich type information that is often lost when just using theraw
value (as was done previously).The way the generation is done, all the previous tests that just used
raw
values are still passing. Additionally, I added a bunch of tests around more specific types of generation.It might also make sense to have a discussion around whether
ArgsTable
should receive the rich type information produced by react-docgen instead of only operating on string values. I think that would resolve issues like #12587 in a cleaner manner.How to test
If your answer is yes to any of these, please make sure to include it in your PR.